larryaasen/upgrader

checkVersion

ktnishide opened this issue · 4 comments

ktnishide commented

Upgrader checkVersion is removed? what is the alternative?

Upgrader version 9.0.0

thanks

larryaasen commented

I see checkVersion right here:

upgrader/lib/src/upgrade_alert.dart

Line 134 in 76e3131

void checkVersion({required BuildContext context}) {

ktnishide commented

Sorry, let me clarify.

We were using upgrader.checkVersion() to programmatically check and display alert when app return to foreground on Upgrader version 6.5.0 but now we realized the package implemented the feature.

Sorry for the misunderstanding.

vladchuk commented

I am still not quite clear on how to check version at will: checkVersion() is no longer on the Upgrader, but on AlertDialog state. What if I can't/don't want to inject the alert into my widget hierarchy?..

Unless I'm missing something, it looks like useful functionality was removed. Can you please explain?

vladchuk commented

I ended up bastardizing UpgradeAlert as follows:

  • make UpgradeAlert a plain class (not a widget)
  • conflate UpgradeAlertState with it, exposing checkVersion(), etc.
  • instantiate alert right after upgrader and use it as before (in v. 8.x.x)

All in all, this feels like a regression. Please consider bringing the original functionality back.