laserdisc-io/fs2-aws

Kinesis: make CommitableRecord.checkpoint() referentially-transparent

chuwy opened this issue · 1 comments

chuwy commented

checkpoint() has Unit return type, while it's clearly side-effectful (as well as canCheckpoint). Wondering if there are technical reasons for not having F[_]: Sync?

No there is no tech reason to keep it this way. CommitableRecord (holding vars of chkpointer and record processor) class and the way we do checkpointing is not good and has to be rethink.