Unused values in `KinesisSettings`
mrdziuban opened this issue · 1 comments
mrdziuban commented
The maxConcurrency
, stsAssumeRole
, and endpoint
values in KinesisSettings
are not used anywhere else in the code. It looks like when they were added they were each used for building a KinesisAsyncClient
in consumer.scala
:
However it looks like consumer.scala
was removed as part of the cats-effect 3 upgrade. Would it make sense to remove these values as well? Or would it make more sense to restore some functionality to build a kinesis client given some KinesisSettings
?
semenodm commented
thanks for reporting the issue. i will address it asap