lassekongo83/adw-gtk3

Praat: window background unthemed

pancaek opened this issue · 4 comments

pancaek commented

Prerequisites

Checklist to make sure the issue is not on your end

  • I have made sure that I do not have multiple versions of the theme installed. Only one version should be installed in either ~/.local/share/themes or /usr/share/themes or ~/.themes
  • The file ~/.config/gtk-3.0/gtk.css does not exist. (If it does, backup and remove it.)
  • I have logged out and in again.
  • Dark theme only. I have enabled adw-gtk3-dark in gnome-tweaks AND set the appearance to dark in gnome-control-center
  • The flatpak theme is installed org.gtk.Gtk3theme.adw-gtk3 and org.gtk.Gtk3theme.adw-gtk3-dark
  • The app I'm having an issue with is an actual GTK3 app and is not coded using another toolkit like GTK2, GTK4, QT, etc.
  • I have created a new user profile without any modifications except adw-gtk3.

Description

When first opening praat,
image
After interacting with the menu (although the dropdown options themselves are correctly themed)
image

I compared the release tags of the last correctly themed version to the next one praat/praat.github.io@v6.4.14...v6.4.16, but I'm not familiar enough with C++ to know exactly the implications of these changes for your theme. I'm happy to close this issue and open one for praat if this is better solved from their end.

OS and version [e.g Fedora 37]

NixOS (24.11 stable)

Adw-gtk3 version. Also specify your installation source. [e.g tar.xz, AUR, git main branch]

5.5 (nixpkgs 24.11 stable)

GNOME version

GNOME 47.1 (X11)

Application name and version (If the issue is with an app.)

Praat (since 6.4.16)

lassekongo83 commented

Seems to be an issue with the app. It breaks the dark theme even with the default adwaita theme.

pancaek commented

Odd, thanks for double checking me then. I'll open something for praat then. Should I leave this open in the meantime or just close it now?

lassekongo83 commented

The issue can be open for now.

Looking further into the issue. It seems the use of gtk_widget_override_background_color in https://github.com/praat/praat/blob/master/sys/GuiDialog.cpp is incorrectly done and is set to a hardcoded value. gtk_widget_override_background_color has been deprecated since 3.16. The correct way should be to use GtkStyleProvider to add a css class.

https://docs.gtk.org/gtk3/method.Widget.override_background_color.html
https://docs.gtk.org/gtk3/iface.StyleProvider.html

pancaek commented

Fixed upstream!