code suggestion....
Closed this issue · 5 comments
Line 1017 in a2956e6
hi cindy,
i have some clients that store html in the categories name. i'm not sure if others do as well, but i think this code would be better (at least for me), if this line was:
$retval = strip_tags($string);
i know if would make my life easier....
thoughts?
I'll buy that, since the two existing filters (punctuation and non-alphabetical) would simply remove the unwanted characters, leaving <h1>
as h1
... which is probably not desirable.
FWIW, I'll plan to use the Zen Cart zen_clean_html
function to get CR/LR/TAB characters out as well.
I also noted that the switch
statement a couple of lines down in the filter
method has the default
first, which doesn't feel right to me, so I'm changing that too as part of this issue.
the zen_clean_html
has the potential to leave beginning and/or ending white space. any chance we could do a trim(zen_clean_html($string))
?
(feel free to call me so demanding now...)
Done (and thanks).
thanks for all you do!