laurentiustamate94/netstandard-storage

Work In Progress?

Opened this issue · 4 comments

assassin316 commented

@laurentiustamate94:

Hi, I have a quick question:

Is this library complete or are there more implementations in progress?

From using PCLStorage, the following is missing:

1) Async implementations (such as CreateFileAsync, GetFileAsync, WriteAllTextAsync, etc.)
2) File.ReadAllText doesn't exist
3) FileSystem.Current.LocalStorage doesn't exist

laurentiustamate94 commented

Hi @assassin316 !

Yes, this is still WIP (currently writing my bachelor so I didn't had much free time)

  1. and 2) will be implemented eventually, as I've already created an issue for inspecting the PCLStorage #2
  2. From where it doesn't exist? The nuget is working, are you referring to this project or PCLStorage?

If you have the time, you can pull request those changes and I will take a look after.

assassin316 commented

@laurentiustamate94

For 2) I'm getting an error when pushing my small PR

 Error encountered while pushing branch to the remote repository: Git failed with a fatal error.
 fatal: unable to access 'https://github.com/laurentiustamate94/netstandard-storage.git/': The requested URL returned error: 403
 Pushing to https://github.com/laurentiustamate94/netstandard-storage.git

For 3), I found the solution: CrossStorage.FileSystem.LocalStorage

laurentiustamate94 commented

@assassin316

Refer to this tutorial of how can you contribute :) [1]
For 3), it made more sense CrossStorage.FileSystem than FileSystem.Current

[1] - http://kbroman.org/github_tutorial/pages/fork.html

abrasat commented

This package looks very promising. Are there any news regarding the implementation of the async functions ?