True full screen mode
Closed this issue · 7 comments
Remember in the old youtube days when you full-screened a video it would stay full screen? Now when you do that, if you scroll down you can actually read the comments that way. In keeping with the spirit of this extension it would be cool if we could remove that behavior.
There was an extension that has this feature but I forget its name.
What do you think?
Good idea! I'll add this the next time I work on RYS
Good idea! I'll add this the next time I work on RYS
Hey, I've seen that you added the label.
How are you gonna approach this? I looked into it for like an hour, and what I came up with was to just toggle display: none
on the bottom container, so that there's nothing to scroll on.
Hi yea I'll probably do something like that. There's a problem I ran into where that approach seems to break the layout when the video is no longer full screen. But there should be a simple way of detecting if its in full screen mode or not.
Hi yea I'll probably do something like that. There's a problem I ran into where that approach seems to break the layout when the video is no longer full screen. But there should be a simple way of detecting if its in full screen mode or not.
What about an event listener that selects .ytp-fullerscreen-edu-button
which is the "arrow down" showing up on fullscreen and check if it has display: none
that YT sets?
EDIT
This seems interesting: https://www.seanmcp.com/articles/listen-for-class-change-in-javascript/
Thanks, sounds promising. I'll check it out.
I tried mutation observers a while ago but it'd cause some lag on slower machines. I might not have configured it well though.
implemented! as of version 4.3.53
. firefox is updated -- and chrome will take a couple days