DataTransfer is not defined in all browsers

Question

DataTransfer is not defined in all browsers

pkaminski opened this issue 8 years ago · 5 comments

I think you need to checkof typeof DataTransfer !== 'undefined' before checking if it has an items property.

Answer 1 · 2016-09-11T11:08:22.000Z

Thanks buddy 😆 good catch!

Answer 2 · 2016-09-21T20:00:59.000Z

Thanks for the fix, but I have bad news: it breaks in IE10 (and older, presumably):
TypeError: Object doesn't support property or method '__lookupGetter__'

I hate IE as much as the next person, but it would probably still be good if Reviewable didn't crash immediately on load if you're stuck using IE10 for some reason.

Answer 3 · 2016-09-22T06:21:43.000Z

@pkaminski I'll fix that quickly, and it seems that I have to set up a cross-browsers CI for not breaking behaviours of the current browser elements.

Answer 4 · 2016-09-22T22:22:03.000Z

No problem, thanks!

Answer 5 · 2016-09-22T23:23:05.000Z

@pkaminski I've shipped the fix with 0.0.21. :)