lazybird/django-solo

Build fail on version 1.2.0 with Django 1.11

encubos opened this issue · 3 comments

encubos commented

Hello,

I'm having a build issue with the new version 1.2.0
Was working without problem with previous version 1.1.5

It is probably related to the Django 1.11 version.

File ".../python3.6/site-packages/solo/admin.py", line 1, in
from django.urls import re_path
ImportError: cannot import name 're_path'

I also found this comment on this PR: #91 (comment)

johnthagen commented

@encubos Django 1.11 is and end of life Django release: https://www.djangoproject.com/download/#supported-versions

Please upgrade to Django 2.2 LTS, 3.1, or 3.2 LTS.

Support for Django 1.11 ended upstream April 1, 2020 and as such there is extra burden to support it.

If you cannot upgrade, consider pinning to an older version of django-solo.

encubos commented

Thanks @johnthagen .

Yes, in my case Is not possible to update Django.
So I solved the issue as you suggest, pinning to an older version. 1.1.5

#In requirements.txt file
django-solo==1.1.5

I just want to report the issue so you know that is there and can be a problem for old django projects.

johnthagen commented

@encubos Thank you for reporting. I'll close the issue but this will be helpful for those who run into this issue. Thanks for sharing your solution.