lazydroid/auto-update-apk-client

Can't upload file

Closed this issue · 7 comments

What steps will reproduce the problem?
1. Trying to upload apk file.
2. After progress bar reach 100% nothing happens.
There is just the following message: "Upload File: 100%, processing ..."


What is the expected output? What do you see instead?
Don't know what is the expected output. This is my first time :-)
I just see information about processing. Trying to wait about 1h, no further 
actions.

What version of the product are you using? On what operating system?


Please provide any additional information below.
App, I'm trying to upload in the attachment

Original issue reported on code.google.com by maciej.b...@gmail.com on 5 Nov 2014 at 3:52

Attachments:

thank you for reporting this problem, I've started to look into that, will 
update this ticket as soon as it's fixed.

Original comment by lenik.terenin on 5 Nov 2014 at 10:53

  • Changed state: Started
Thx, looking forward to.

Original comment by maciej.b...@gmail.com on 6 Nov 2014 at 6:56

I've checked your apk file and found the application label='Telefon
Interwencyjny', that is application label='Telefon\nInterwencyjny' -- there's a 
line break inside of your application label. This is very strange, and you may 
want to check this. In case this was intentional, I have changed the server 
scripts to ignore the line breaks inside the application labels and you may try 
to reupload your original APK file again.

Please, tell me if you have any other problem uploading the file?

Original comment by lenik.terenin on 6 Nov 2014 at 10:28

  • Changed state: Fixed
Hi,

thx for the support.
Now everything works perfectly :-)

One question, I've assumed, your parser had interpreted new line character in 
the string as the end of the current line of the manifest, so it looked like 
the manifest file is corrupted (invalid xml format) ?

Regards!!!

Original comment by maciej.b...@gmail.com on 7 Nov 2014 at 12:18

when you create .apk file, manifest xml gets compiled into a binary format, so 
there's no problem with xml parsing. the problem was, the application label 
basically should not contain line feed, carriage return or tabulation 
characters and the parser tripped error instead of the warning it should give. 
it could have and should have continued parsing like nothing happened, but 
somehow decided to fail and complain instead. it was severely punished for this 
misbehaviour and hopefully won't do that again any time soon.

Original comment by lenik.terenin on 8 Nov 2014 at 10:55

Ok, but still, you decrypt the manifest, from apk file, to the xml and then it 
is parsed ? :-).

Anyway, thx for the support!

Original comment by maciej.b...@gmail.com on 8 Nov 2014 at 12:34

there's no XML at any stage. there are two files in the APK: 
AndroidManifest.xml and resources.arsc, that are binaries and have nothing to 
do with XML besides the name. these files are parsed to extract the application 
name and other info, if you are interested, you may take a look at "aapt" 
utility, that does about the same.

Original comment by lenik.terenin on 8 Nov 2014 at 1:06