Using dynamic `require` instead of `import` in tests hides typescript errors.

Question

Using dynamic `require` instead of `import` in tests hides typescript errors.

rudolfbyker opened this issue 3 years ago · 3 comments

The tests use require('...') to import from the library, and it's using a dynamically calculated variable from the environment to determine the path. This is hiding a lot of Typescript errors that currently exist in the tests.

kibertoad commented 3 years ago

Good one!

Answer 1 · 2021-08-30T15:10:04.000Z

I have a feeling we should replace ALL requires with imports, and remove '@typescript-eslint/no-var-requires': 'off', from the eslint config.

Answer 2 · 2021-08-30T16:32:58.000Z

Yes, we definitely should.