lbl-srg/funnel

tubeSize.c hard-coded what seems to be a tolerance

Closed this issue · 2 comments

tubeSize.c contains

	if (maxX != minX) {
		ratio = max(0.0004, ((maxY - minY + abs(minY)) / (maxX - minX)));
	} else {
		ratio = 0;
	}

It is not clear what 0.0004 is. Should this scale with the tolerance? Also, maxX and minX are double and hence need to be compared within a tolerance.

Note, that we propsed to change it by modelica-tools/csv-compare@9818b33

@JayHuLBL Please also add the changes from the modelica-tools repository to our implementation.