lda-project/lda

Python 3.8 wheels are not available

Closed this issue · 7 comments

ariddell commented

Title says it all.

Dropping Python 3.5 wheels could also occur as part of this fix.

internaut commented

What is the current status of this? Python 3.8 is becoming the standard in many Linux distributions, e.g. the current Ubuntu 20.04 LTS. At the moment, it's not possible to install lda right away in this context.

I could build and run lda from the develop branch without problems on Ubuntu 20.04 / Python 3.8. All tests run well for Python 3.6 through Python 3.8 via tox. I couldn't test Windows or MacOS though.

So, publishing wheels for Python 3.8 should be quite straight forward. Are there still some problems I'm not aware of?

m13253 commented

I couldn't test Windows or MacOS though.

Installing lda using pip3.8 install lda produces the following error on macOS 10.15.4:
https://gist.github.com/m13253/99965721362fbd9c63a5a1eedcc2d4dc

internaut commented

Installing lda using pip3.8 install lda produces the following error on macOS 10.15.4:
https://gist.github.com/m13253/99965721362fbd9c63a5a1eedcc2d4dc

This is the error you receive because there are no precompiled wheels for lda on 3.8 and it tries to compile the source downloaded from PyPI which fails.

The question is however, whether the current source from the GitHub develop branch compiles under MacOS, which means you would need to checkout and build.

Anyway since there's no activity on this, I'm thinking about forking the project and providing wheels for that fork.

m13253 commented

The question is however, whether the current source from the GitHub develop branch compiles under MacOS, which means you would need to checkout and build.

I am a little bit puzzled on how I should build the source.
I tried python3.8 setup.py build, but it throws me an error:

building 'lda._lda' extension
creating build/temp.macosx-10.15-x86_64-3.8
creating build/temp.macosx-10.15-x86_64-3.8/lda
clang -Wno-unused-result -Wsign-compare -Wunreachable-code -fno-common -dynamic -DNDEBUG -g -fwrapv -O3 -Wall -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk -I/Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/usr/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/Tk.framework/Versions/8.5/Headers -I/usr/local/include -I/usr/local/opt/openssl@1.1/include -I/usr/local/opt/sqlite/include -I/usr/local/Cellar/python@3.8/3.8.2/Frameworks/Python.framework/Versions/3.8/include/python3.8 -c lda/_lda.c -o build/temp.macosx-10.15-x86_64-3.8/lda/_lda.o
clang: error: no such file or directory: 'lda/_lda.c'
clang: error: no input files

Would you please give me an instruction on how should I build it?

m13253 commented

I confirm the package builds successfully on macOS 10.15.4 and Python 3.8.

The example code in Readme file also runs fine.

  • 👍1
ariddell commented

Python 3.8 wheels are up. No windows wheels because appveyor seems to have changed their config format. There is a source distribution which Windows users should be able to build.

  • 👍1