league-of-legends-devs/LoL-item-sets-Mac

[Breaking change] Changing the website API style

Closed this issue · 4 comments

Hello.

As I am currently changing the website API, some "endpoints" won't be supported anymore once the new website is deployed. This will eventually break the app.

All API endpoints will be JSON strings.
Here are the "future broken" endpoints :

There will also be a /api/news endpoint containing to potential text to show in the app. Output example : {"text":"We are sorry to announce that the ProBuilds build order will be disabled until we manage to fix the generator. Stay tuned !"}

I made a temporarily copy of the website on (edit: removed) for debugging purposes ;-)

The website will be deployed right after the release of the new functional Windows and Mac apps :)

Ok, I will start updating all the stuff.

Only one question, on /api/news/ if there's nothing to show, will return something like {"text": null}?

Thank you ! It will return {"text": ''} (empty string).
The generationDate field is a serialized (Javascript) Date type using JSON.stringify.

With 9805a13 all changes are uploaded to the repo and the update is ready

Wow, thanks a lot for the very fast changes !
I will now close this issue once the migration process is done.