wget doesn't show progress
Closed this issue · 7 comments
When using this from my spotify-make branch of opensuse-spotify-installer, it apparently hangs at:
wget -q -O spotify-client_0.9.0.133.gd18ed58.259-1_amd64.deb http://repository.spotify.com/pool/non-free/s/spotify/spotify-client_0.9.0.133.gd18ed58.259-1_amd64.deb
Of course, it's not a real hang, it's just downloading - but the user doesn't know that :) So it would be better to drop the -q.
SInce spotify-make is primarely designed as a batch tool it's not possible to remove the -q flag in the default mode. The progress reports would create a mess in all sorts of logfiles storing results from running s-m. One obvious example is when s-m is invoked as part of rpmbuild when packaging.
One possible way would be to add an option like -v/--verbose or -i/--interactive which turns on this behaviour. I don't feel this is an important enough feature to spend time on it, but patches are welcome.
The standard way to deal with this is to automatically detect whether STDIN is a tty or not: [ -t 0 ]. Iff not, use -q.
Also I'm not sure why you say it's primarily designed as a batch tool? Isn't one of the standard use cases going to be invocation from opensuse-spotify-installer? Anyway, I'll produce a patch for this, so please reopen.
It's just that s-m is a a batch-oriented tool providing standard make feedback, which certainly not includes progress reports using updated lines like those from wget. So, basically I'm against any patch giving wget progress reports unless explicitly requested with an option or so.
his shouldn't be a problem from the suse usecase, since s-m there is run from another script.
I havn't closed it... :)
Oh yeah :) But why not auto-detect whether it's running in batch mode or not? Surely that is by far the easiest thing to do, and suits all cases.
There is no more input on this. Nor is there any other input on the output being too dense. Closing, please feel free to reopen if you feel it's justified.