Shouldn't we remove the committed vendor directory ?

Question

Shouldn't we remove the committed vendor directory ?

dgsb opened this issue 6 years ago · 5 comments

Answer 1 · 2018-08-24T09:49:47.000Z

I do not think so. Balancing pros and cons and since this repository is not so big with not so many dependencies, I would rather stick to commit the vendor.

Ref: https://github.com/golang/dep/blob/master/docs/FAQ.md#should-i-commit-my-vendor-directory

Answer 2 · 2018-08-24T09:59:43.000Z

Is is going to be practical for library consumer ?

Answer 3 · 2018-08-24T11:17:08.000Z

I've checked randomly a few go libraries and applications, committing the vendor is not something which is commonly done for library.

Answer 4 · 2019-02-08T09:45:04.000Z

Hi!

I agree with @dgsb. It doesn't seems a common practice for open-source libraries.

Answer 5 · 2019-02-08T09:51:40.000Z

Can you propose a PR for this ?