username not working
Opened this issue · 4 comments
Can't specify a username and have it applied. The code here does not look like it passes it on.
https://github.com/lecardozo/rworker/blob/master/R/redis_queue.R#L38-L67
Hi! Thanks for the interest in the library. 😄
It seems like the username is actually ignored on here on richfitz/redux, which is the client library we rely on for connecting with Redis. If this is an important feature for you, I recommend checking the richfitz/redux repo and contributing with a PR. After merge/release, it should be pretty straightforward for us to update rworker's code to pass the username downstream.
from what I understand, its just building the "auth" command, and in auth there are two forms. password and "username password" (https://redis.io/commands/auth)
so I think in that case the lib still works and you just pass the equiv of "%s %s" %(username, password) as the password?
That indeed seems to be the case! Have you tried just passing both user and password in rworker's password argument to see if it works as expected? I can't check now, but I'll be glad to review any PRs implementing the user-pass concat workaround if it solves the problem :)
It doesn't work when I tried it. I think it may have to do with how things are parsed out of the url.