ledger-rs/dinero-rs

One test not passing in windows?

Opened this issue · 3 comments

frosklis commented

@MikeTheSapien pointed out that one of the tests is not passing in windows.

Steps to solve:

  • Understand why
  • Maybe Set up ci pipeline in a windows machine so that it shows up
  • Fix
MikeTheSapien commented

Hello there. I can maybe tackle this task.
I'll attempt to understand your code and why I'm having this problem.

The uncertainty and doubts from my part are coming from my lack of experience. I only have ~10k lines of code made in Rust (currently in use in production as well) so far. 4 years into programming (mostly in Java and Python, mostly back-end), 10 years being an accountant. Software development is a recent career change.

So please be explicit if I'm doing anything stupid or offensive or anything wrong.

PS. Sorry if I wrote this piece of mine here 😅 don't know where else to put this so you may have an understanding of my competency, or lack of it.

  • 👍1
frosklis commented

Hello there. I can maybe tackle this task.
I'll attempt to understand your code and why I'm having this problem.

I don't know exactly how github actions work, and I don't have access to a Windows machine myself for this. So the first thing would be to isolate the issue.

Then maybe a test can be automated in a windows machine. Maybe this helps?

MikeTheSapien commented

Thanks for the reference! I’ll tackle it.