ledgersmb/LedgerSMB

Hyperlink from trial balance screen broken for unapproved transactions

Closed this issue · 1 comments

Version

LedgerSMB 1.11.12

What browsers are you seeing the problem on?

Firefox, This problem isn't browser related

What happened?

When you generate a "trial balance" report and select "All Transactions" LedgerSMB uses a URL similar to:
http://localhost:5762/erp.pl?__action=root#/trial_balance.pl?__action=run&bc_count=0&from_date=&to_date=&from_month=03&from_year=2021&interval=year&is_approved=All&balance_sign=0&tb_type=sql-ledger#2

Note the "&is_approved=All" qualifier

When you click on an account number on that screen, LedgerSMB opens a URL of format:
http://localhost:5762/erp.pl?__action=root#/journal.pl?__action=search&col_running_balance=Y&col_transdate=Y&col_reference=Y&col_description=Y&col_debits=Y&col_credits=Y&col_source=Y&col_accno=Y&accno=10010&from_date=2021-03-01&to_date=2022-02-28

The "&is_approved=All" qualifier is missing. The report does not show the unapproved transactions which were on the Trial Balance and totals etc are wrong.

What should have happened?

If the &is_approved=All qualifier is manually added to the URL as follows:

http://localhost:5762/erp.pl?__action=root#/journal.pl?__action=search&col_running_balance=Y&col_transdate=Y&col_reference=Y&col_description=Y&col_debits=Y&col_credits=Y&col_source=Y&col_accno=Y&accno=10010&from_date=2021-03-01&to_date=2022-02-28&is_approved=All

The missing transactions and expected totals are displayed.

The script used to generate the original Trial Balance page should be fixed to carry over this setting into the generated hyperlinks.

Thanks!

Ian

Thank you for reporting!

I have identified the issue and will be fixing shortly. While you reported, the release procedure for 1.11.13 was running, meaning the fix will be published in 1.11.14 in 2 or 3 weeks.