ledgersmb/LedgerSMB

Can't turn off FX checkmark on (saved) GL journal

Opened this issue · 1 comments

Version

1.11.14

What browsers are you seeing the problem on?

This problem isn't browser related

What happened?

When unchecking the FX checkmark, followed by Save, the FX lines reappear.

What should have happened?

The FX-ness of the transaction should have been removed.

I've identified the cause to be

if ( $form->{id} ) {

in combination with

$form->{fx_transaction} ||=
($ref->{curr} ne $form->{currencies}->[0]);

Which means that on saved transactions the fx setting is overruled with the saved data on every "Update" roundtrip.