The `table` argument in `rio.db:::.import.rio_sqlite`: renaming or adding a `which` argument
Opened this issue · 3 comments
Suggested enhancement for consistency with rio
.
Here is the current call signature:
> args(rio.db:::.import.rio_sqlite)
function (file, table, ...)
The table
argument plays the same role here as the which
argument does in all the rio
import functions. If there aren't a lot of packages depending on this one (and maybe there aren't since this isn't on CRAN) then can table
be renamed to which
?
Otherwise, can we alter the call signature as follows?
function (file, which, table = which, ...)
Great idea.
This was mostly proof-of-concept - I was never sure if I was actually going to put this on CRAN. Would be happy to have you collaborate on it, if you think it's useful.
I absolutely think it's useful. One of my goals is to solve the "mystery file" problem and sqlite files are among the ones I've seen getting sent to researchers who have no idea how to open them.
So are you okay with the simpler approach of renaming the second argument?
Yep!