leewillis77/wp-github-oembed

Plugin not working on wordpress 3.5.2

Closed this issue · 14 comments

I've installed and activated the plugin on wordpress 3.5.2 but when I add the following line to my wordpress page nothing happens.

https://github.com/keeps/roda/contributors

Is there any known incompatibility with this wordpress version?

Hi,

It should work just fine on WP 3.5.2 - indeed I set it up on a site running that just last night. The main thing to check is that you're pasting the URL as text (Not a link, and not with any other text, or formatting), and that it's the only thing on the line.

It could also be affected by caching if you have any enabled, but I doubt it.

Dear Leewillis,

I don't think cache is the problem. I've tried different browsers and even cleaned the cache with the same effect.

The problem is that the URL is not being transformed into to the right HTML. We do have a custom theme installed. Will that have any influence?

PS: Pasting a URL to YouTube works fine with the oEmbed functionality.

Added some screenshots that might help understand the problem.

screen shot 2013-06-28 at 13 55 34

screen shot 2013-06-28 at 13 51 25
screen shot 2013-06-28 at 13 45 48

Hi, I've fixed this. It looks like it only affected contributor embeds when the server was set to display errors.

Hi leewillis,

Thanks for the update. Will this be available via the standard update procedure on wordpress soon?

Hi,

It'll be in the next release, but I'm not planning on doing a release just for this. It's easy to avoid - just turn off PHP warning display - that shouldn't be enabled on a production site anyway. Alternatively, if that's not feasible for some reason, you can manually make the change as per the commit above - it's just a one-line deletion.

Hi @leewillis77, I'm a colleague of @jmaferreira.

The problem still persists, I have cleaned the cache several times, deleting all entries in postmeta table with a key that starts with _oembed_. I must say the the contents of these entries are a bit strange:

mysql> select * from wp_postmeta WHERE meta_key LIKE '_oembed_%';
+---------+---------+------------------------------------------+-------------+
| meta_id | post_id | meta_key                                 | meta_value  |
+---------+---------+------------------------------------------+-------------+
|    1293 |     513 | _oembed_1e7797203e632453a5540d3554942392 | {{unknown}} |
+---------+---------+------------------------------------------+-------------+
1 row in set (0.00 sec)

Still, the plugin is not able to show the github page. I have follow your suggestions and disable error reporting by adding to wp_config.php the lines.

error_reporting(0);
@ini_set('display_errors',0);

And replicated on the plugin source the changes you have done in commits d9f34d2 and 769bf73.

The oembed entries in the postmeta table are always created but nothing else seems to be happening. Any other ideas on how to fix or diagnose this problem?

Hi Luis,

That certainly looks strange. It's possible you've been temporarily blocked by Github if you've been testing frequently. If you set the GITHUB_API_LEVEL back to GEDEBUG_RESP then all of the API calls will logged into your error log - that may give you an indication of what's not working.

If that doesn't help, happy to take a look if you want to send me some login details >> http://www.leewillis.co.uk/contact/

Hey @leewillis77, I found out what was the problem. We had the site protected with basic auth while it was not finished. After removing basic auth it worked. But this may just have been a coincidence and we may just stopped being blocked by GitHub. Nevertheless, thank you for your help and your work with this awesome plugin!

One last question dough, it seems that it is only showing the top contributor, checkout:

http://www.roda-community.org/developers/

There are 3 contributors on GitHub but only one appears on the page.

It looks like the GitHub API will only return people who have access to the repo itself - I've logged a request with their API support team to see if I've misunderstood the API, or if a new call can be added to get this info.

Thanks.

For info, this is fixed by the latest commit to use a better API which should produce the info you're after.

@leewillis77, just to inform you that the latest commit does solve the problem for us.

http://www.roda-community.org/developers/

Thanks you, and keep up the good work!

Great work guys. Thanks.