lefoy/cyanide-theme

Cyanide name in tmLanguage files?

Closed this issue · 7 comments

lefoy commented

@Centril, quick question, why did you add Cyanide before language name in language.hidden-tmLanguage?

<dict>
    <key>name</key>
    <string>Cyanide {{lang}}</string>
    <key>fileTypes</key>
    ...

I'm not sure I would keep the prefix, but I just want to be sure I'm not missing something =)

Centril commented

Because when someone has actually installed for example the CoffeScript sublime plugin, it ships with actual syntax highlighting which is named "Coffescript".

And to differentiate between "Coffescript" and the dummy "Cyanide Coffescript", the prefix is needed.

lefoy commented

The only problem I have with this is that I have some plugins that automatically lint files depending on the syntax but they don't work anymore because they can't recognize syntax (because of the prefix).

For example:

Screenshot

It used to detect "Javascript". I'm not sure how we could solve this, any idea?

Centril commented

Does it work w/o the prefix? Can it detect "Gruntfile JS" as "Javascript"?

lefoy commented

It doesn't work with "Gruntfile JS" either, but I guess it's a problem with the plugin.

If we remove the prefix, would the Coffescript syntax from the plugin overwrite the one from Cyanide?

Centril commented

I guess one of them would overwrite the other... which depends on what file is loaded first, from the plugin or the theme... It is not really clear which one it is - so therefore I think we should keep the prefix to avoid the conflict.

lefoy commented

I removed the prefix locally and I can't see any difference with the Coffeescript or with the Sass plugin.

I'll probably remove the prefix for the next release and if we find any conflit with other plugin, I'll find another way to differentiate files.

Centril commented

Aight, let's test and see how it goes ;)