leoding86/pixiv-omina

No distinction by colour

Closed this issue · 6 comments

Omina Version
~0.8.0

What's the problem
It used to be amazing to have Manga, Illustration, etc. of a distinct colours, whereas now:

Screenshot

Post scriptum
All in blues gives me blues...

Also, I do not quite understand significance of the word "Pixiv" before its category.
Shouldn't it be plain even without it?

I suggest to remove it.

the artwork I download registers as manga too not just the color

@JazzXin Well, yes, because I built it from current master. That is why I mentioned ~0.8.0. The fix is not present in 0.8.0 release. Here is the issue #67.

Nevertheless, I am using ~0.7.7(couple commits after release) presently, until/if this will be fixed. For it might have been intended change.
Although changing it back might be a couple lines, I have no intention of doing it for now. (^^ゞ

@sakkamade Sorry, I don't use github often besides downloading releases so checking closed issues didn't come to my mind. I'm currently content with using version 0.7.7. If I find any issues with it, I'll change to the version ~0.7.7 or ~0.8.0 that you mentioned. Thanks for clarifying it for me.

Also I totally agree with your take. All tags being blue is not a good choice if it is intended.

If I find any issues with it, I'll change to the version ~0.7.7

You don't have to worry about it, for, as far as I remember,
there was no particular issues with 0.7.7 .exe release,
the problem is within its .tar.gz and .zip variations.

Nevertheless, we shouldn't stick with old versions if we are able to correct,
point out the issues, and improve newer software.
Well, of course, the main words are the ones of maintainer.

I guess this was fixed with 7d8cd8d, however I cannot check it now. Closing.

P.s.

Should not this be be this.tagColor?