leonardochaia/dotnet-affected

Finding affected projects take longer then expected

omer-za opened this issue · 2 comments

Hi, I have cases when finding affected projects takes more then 10 minutes, then I abort my job and can't continue from this point.
I suggest to have an option to configure timeout and if timeout reached then mark all solution as affected (all csproj files).

We have a big solution project and sometimes when there's a lot of changes and it just hangs forever :(

Hi @omer-za
What version of dotnet-affected and dotnet SDK are you using?

Have you tried dotnet-affected v3-preview-3?
Several improvements where made on how affected project detection works.

I haven't run the benchmarks in a while but the MacroBenchmark, which I don't know how much we can trust it's results, benchmarked 1k projects in ~5.6s

It would be very nice to improve performance, so perhaps the benchmarks are not good enough or there's something different with your solution.

We use dotnet sdk 6.0.404 and version 2.2.0 of the tool.
It doesn't happen much when it hangs, only when a lot of files changes in our solution which contains around 300 projects