leonderijke/jQuery-Modern-Blink

Promise does not work

Closed this issue · 3 comments

Thank you for useful plugin. However either I don't get something or... -- you wrote, "Modern Blink provides the behavior of the blink tag using CSS Animations. Will fallback to jQuery Animations in older browsers."

It is not a matter of older/newer browser. If you create a plugin that operates outside jQuery it means it is not 100% compatible with jQuery. First thing I notice -- "promise" is broken.

One way to fix it (simple way) would be to add another option -- "mode" (with values "css"/"jquery"). Default mode should be jquery -- for the reason mentioned above, 100% compatibility.

The plugin interface is a jQuery plugin, no matter if CSS Animations or jQuery Animations are used. I don't see why that is not compatible with jQuery.

Because it is controlled by end-user browser really. In other words -- because the way my app is build I need to rely on jQuery Animations. Now, it is impossible to do, despite the fact it is fully supported. The plugin is too smart and takes too much control over its behavior.

The automatic switching (fallback) is one of the main features of this plugin. If you need to rely on jQuery Animations, I'd suggest creating your own plugin or forking this one. Or just use jQuery Animations directly, without a plugin.