leper/0ad

TODO comments

Closed this issue · 5 comments

Yves-G commented

Having a look at everything with 'TODO TODO TODO' next to it (mostly checking that it is translated)

Gallaecio commented

Please, create separate Github issues for those items. Leper wants more emails :)

Gallaecio commented

I’ll take a look at it. From grep:

binaries/data/mods/public/gui/savedgames/load.js:               // TODO TODO TODO
binaries/data/mods/public/gui/lobby/lobby.js:// TODO TODO TODO check where this is used and why
binaries/data/mods/public/gui/lobby/lobby.js:   // TODO TODO TODO
binaries/data/mods/public/gui/summary/summary.xml:                                      <!-- TODO TODO TODO -->
binaries/data/mods/public/gui/summary/summary.xml:                                      <!-- TODO TODO TODO -->
binaries/data/mods/public/gui/summary/summary.xml:                                      <!-- TODO TODO TODO -->
binaries/data/mods/public/gui/summary/summary.xml:                                      <!-- TODO TODO TODO -->
binaries/data/mods/public/gui/civinfo/civinfo.js:       // TODO TODO TODO escape " in translated tooltips
binaries/data/mods/public/gui/session/utility_functions.js:             // TODO TODO TODO color, font
binaries/data/mods/public/gui/session/utility_functions.js:     // TODO TODO TODO color, font
binaries/data/mods/public/gui/session/messages.js:      // TODO TODO TODO 
binaries/data/mods/public/gui/session/unit_commands.js: // TODO TODO TODO
binaries/data/mods/public/gui/session/unit_commands.js:                         // TODO TODO TODO
binaries/data/mods/public/gui/session/unit_commands.js:                         // TODO TODO TODO
binaries/data/mods/public/gui/session/unit_commands.js:                 // TODO TODO TODO
binaries/data/mods/public/gui/common/functions_utility_loadsave.js:     // TODO TODO TODO metadata.time is a unix timestamp (seconds)
sanderd17 commented

Any progress? I can take a look too, but I don't like double work.

Gallaecio commented

I had trouble after building the game, as if sprintf.js was not there. I did build without cleaning up first, trying that now. If I can get the game to run without issues, I’ll have every TODO either done or separated into a different Github task in the next hours.

Gallaecio commented

I took care of all of those that had to do with i18n. There were two about font and color.