lerna/lerna-changelog

listCommits – issue with "git log --pretty" delimiter if there is ";" symbols in commits tags

Closed this issue · 0 comments

Not a bug, but incorrect behavior

lerna-changelog uses ; as a delimiter for git log --pretty and then split by it to get commit info.

https://github.com/lerna/lerna-changelog/blob/master/src/git.ts#L36

Our CI uses ; symbol for tags labels and automatically adds it to the commits. For example, RC;.;1.164.0.

That's why lerna-changelog can not parse commits properly in out case.

I am going to make PR to fix this.

There are a few options:

  • Add option to set the delimiter symbol
  • Update listCommits function – find another way to get commits info or use RegExp.

I like the way with RegExp.

BTW the same issue will be if use ; in commit messages.