Constants for COMMAND and RESPONSE_AUTH are the same

Question

Constants for COMMAND and RESPONSE_AUTH are the same

Closed this issue 6 years ago · 5 comments

This simply seems problematic to me. Can you explain?

Answer 1 · 2018-04-21T17:53:08.000Z

It's defined like that in the spec.
See https://developer.valvesoftware.com/wiki/Source_RCON_Protocol#Requests_and_Responses and http://wiki.vg/RCON#3:_Login

Answer 2 · 2018-04-21T21:04:51.000Z

Ok got it. It's the same for different operations.
Just finished this:
https://github.com/electricessence/rcon-ts (fork of your repo)

Answer 3 · 2018-04-22T10:56:09.000Z

@electricessence Why didn't you contribute typings to this repo? Just curious 🙂

Answer 4 · 2018-04-22T17:58:49.000Z

I'm all for starting a pull request, but I've gone beyond just adding a *.d.ts.
Once you switch to TS, certain patterns show up. The *.js and *.d.ts files are in NPM.

Answer 5 · 2018-04-22T20:00:15.000Z

I'm still working out the kinks too. Remember to include them in your package.json as "typings":"[name].d.ts".
rcon.d.ts.zip

Here's the current d.ts file as it's being rendered. It's going to be different than yours but might be useful with a few tweaks.