lewis6991/hover.nvim

hover.hover() position is off by 1

Closed this issue ยท 3 comments

flrgh commented

Hiya ๐Ÿ‘‹

Today after updating the plugin to bb3dc1a I noticed that require("hover").hover() yields a result for $current_line + 1 instead of $current_line:

Screenshot from 2023-11-11 13-49-54

Screenshot from 2023-11-11 13-50-05

Here is my lazy.nvim package def and config for hover.nvim:

{
  "lewis6991/hover.nvim",
  event = "VeryLazy",
  config = function()
    require("hover").setup({
      init = function()
        require("hover.providers.lsp")
        require("hover.providers.man")
        require("hover.providers.gh")
      end,
      preview_opts = {
        border = nil,
      },
      title = true,
    })
  end,
}

...and I have a normal mode keymap for K which just calls require("hover").hover(). I can also reproduce the problem by running this without the keymap (e.g. :lua require("hover").hover()).

All of my other LSP mappings (definition, declaration, code-action, etc all work normally) are working fine.

Reverting to 24369e8 fixes the problem, so I suspect that there might be some unintentional breakage from these two recent commits

I'll try to writeup a minimal repro config when time permits. If there's anything else I can do to help troubleshoot in the meantime, lemme know!

No repro necessary. Should be easy to fix.

My PR #44 fixes this.

Closed in 3ff5bbb