lextudio/sharpsnmplib

Is it right [Obsolete] attribute are set in different overloads between GetRequestMessage and SetRequestMessage ?

MORI-HAMAMATSU opened this issue · 1 comments

MORI-HAMAMATSU commented

Obsolete attribute of GetRequestMessage and SetRequestMessage constructor are set in different overloads currently as below.

  • GetRequestMessage constructor

    GetRequestMessage(int, VersionCode, OctetString, IList< Variable >)
    GetRequestMessage(VersionCode, int, int, OctetString, IList< Variable >, IPrivacyProvider, ISnmpMessage) ... OBSOLETE
    GetRequestMessage(VersionCode, int, int, OctetString, IList< Variable >, IPrivacyProvider, int, ISnmpMessage)
    GetRequestMessage(VersionCode, int, int, OctetString, OctetString, IList< Variable >, IPrivacyProvider, int, ISnmpMessage)

  • SetRequestMessage constructor

    SetRequestMessage(int, VersionCode, OctetString, IList< Variable >)
    SetRequestMessage(VersionCode, int, int, OctetString, IList< Variable >, IPrivacyProvider, ISnmpMessage)
    SetRequestMessage(VersionCode, int, int, OctetString, IList< Variable >, IPrivacyProvider, int, ISnmpMessage) ... OBSOLETE
    SetRequestMessage(VersionCode, int, int, OctetString, OctetString, IList< Variable >, IPrivacyProvider, int, ISnmpMessage)

I think maybe obsolete attribute of SetRequestMessage constructor is set in wrong overload.
(Maybe SetRequestMessage(VersionCode, int, int, OctetString, IList< Variable >, IPrivacyProvider, ISnmpMessage) should be set obsolete)

These changes were done in Removed obsolete attributes.

image

Is there are any historical reason of this?
Or obsolete attribute of SetRequestMessage constructor is set in wrong overload ?

Your confirmation would be appreciated.

lextm commented

Actually more obsolete notes should be added. Fixed in cbe8cdc