Illegal redeclared variable: global

Question

Illegal redeclared variable: global

Closed this issue 3 years ago · 9 comments

I'm getting an error when trying to compile this in a ClojureScript project that looks like this:

Closure compilation failed with 1 errors
--- node_modules/@lezer/php/dist/index.cjs:50
Illegal redeclared variable: global

Here's a branch of a repo that replicates the error. I don't have time to check if this happens in a JS project too.

Answer 1 · 2021-11-04T20:51:06.000Z

There's no restriction in JavaScript against declaring a variable named global, so I'd say this is a problem with ClojureScript.

Answer 2 · 2021-11-05T00:46:55.000Z

Yes, we renamed the variable to _global manually and it started working. :P

Answer 3 · 2021-12-20T08:34:24.000Z

This is a problem with google/closure-compiler (discovered via google/closure-compiler#2471).

Answer 4 · 2021-12-20T08:43:41.000Z

Right. Closing this, since I don't plan to accommodate it on this side.

Answer 5 · 2022-09-13T00:17:26.000Z

@marijnh so.. this gives an error and make the package unusable, what can we do?

PS: im not using clojure, just js + vite

Answer 6 · 2022-09-13T06:21:01.000Z

what can we do?

Figure out what's going wrong, possibly open a new bug if you think this package is to blame. Declaring a variable named global locally is valid JavaScript, so I suspect you're using some build/runtime tool that is broken.

Answer 7 · 2022-09-13T09:02:07.000Z

what can we do?

Figure out what's going wrong, possibly open a new bug if you think this package is to blame. Declaring a variable named global locally is valid JavaScript, so I suspect you're using some build/runtime tool that is broken.

i changed globalfor _global and it works. can I submit a PR? I'm using typescript, node and vite, nothing special

Answer 8 · 2022-09-13T09:16:52.000Z

I really don't want to adjust code to work around bugs, especially untriaged bugs, in other software.

Answer 9 · 2022-09-13T09:25:20.000Z

I really don't want to adjust code to work around bugs, especially untriaged bugs, in other software.

what other software? typescript/vite you mean? there is already a lot of variables that start with _, like _interface, so why not just have another? why you want this grammar to break when no other does? It's just changing a variable name that doesn't affect anything.

I can help you debug the issue if you guide me or tell me what you need, but I'm using node, not a weird broken runtime. I don't understand why you don't want to fix this. It's easy and doesn't cause any trouble.

10:20:34 AM [vite] Internal server error: Identifier 'global' has already been declared

I don't know where the problem really is, but all the things I'm using are so popular, so i'm not the last one encountering this issue.

If you don't want to fix the grammar, it's ok.