Cyclic dependency upon clj
arpunk opened this issue · 11 comments
In order to test lfex/clj one needs to specify ltest as a dependency, but currently ltest depends on clj. Is there a way to skip this check? I'm using rebar3.
Yeah, I've run across this in various places -- tried to fix them up. I think I've ended up settling on not having ltest as a dep of clj -- the tests for clj being something that developers and contributors would deal with more than anyone else, and they would be most able to handle a custom scenario.
Maybe I just just do something outside the tool for this ... the lfe.config file has been used in the past to circumvent cyclic dependencies. A goofy make target would also "work" ...
Anyway, I'll remove the dep from clj for starters -- let me know how that works for you.
(This also makes sense, since a good chunk of clj is on the roadmap for inclusion in LFE as a core library ...)
Huh ... the latest clj doesn't depend upon ltest, so I must had already addressed this. I'll check the versions released (and in the rebar.config file(s) ...)
Yeah, just found where the dep was removed (for this very problem):
That was Apr 20, 2015 ... version 0.3.0 of clj was released on Oct 2015. Hrm, and ltest depende upon 0.3.0.
I wonder -- maybe you have an outdated version of clj in your ~/.lfe directory somewhere?
Hey @oubiwann, just saw this. Sorry for that.
No, I do not have a ~/.lfe dir, however let me try again with fresh deps to see if I can replicate the issue.
You are right, ltest was removed from clj and now it builds and test passes. clj test doesn't run because there are no ltest macros available. Shall I open an issue in clj or do you have plans for it?
No worries.
I think we're going to add a test profile in the rebar.config file to allow for tests to be run (using rebar3 as test eunit) while avoiding cyclic deps ... pretty sure there's a ticket for that.
ping
@yurrriq I'm using ltest latest with rebar3 so I guess this is not an issue anymore? I'm also using LFE v1.1.1
👍
Okay, I'll close ... we can re-open (or create a new ticket) if it crops up again.