Remove source defaulting
Closed this issue · 4 comments
I don't think it's a good idea to use a fixture and dynamic binds and stuff. It's not explicit enough imo.
Need some way of providing a source in defprop though. Not sure what that'll look like, yet.
Since defprop is already a macro, could walk through looking for calls to generators and inserting a source. Might need to make second versions of every generator though.
Actually leaning back the other way now. Might move source to the last argument of all the generators so you can partial them, however?
Ok, so take three. I'm going to change it all to use the dynamically bound var.
Rather than getting the defprop style thing working, I'm going to provide (eventually) alternate ways of supplying a source for a particular test.
This is done, but has introduced some issues. I can't tell what test var is running inside a test fixture, and that makes it hard to configure a particular test, or disable the repetition (which I want to do for some of the tests of the apis), or supply a different source. CLJ-840 seems to provide an answer to this, so I'll try and get that done, basically.