lgommans/presentation-feedback

Mysql 8 Database Error

Opened this issue · 2 comments

On mysql 8 get an Error while sending the feedback:

mysql --version
mysql Ver 8.0.20-0ubuntu0.20.04.1 for Linux on x86_64 ((Ubuntu))

grafik

Questions are OK:

grafik

grafik

Any hints what to do?

I figured out the problem: The VARCHAR variable in the dbsetup.php query is too big:

	$db->query('CREATE TABLE presentation_question_responses (
		id INT PRIMARY KEY AUTO_INCREMENT NOT NULL,
		feedbackid INT NOT NULL,
		sequenceNumber INT NOT NULL,
		response VARCHAR(35000)
		)') or die(translate('dberr') . '14717');

I changed 35000 to 15000 and it worked fine. So all database tables are there. No Database errors while giving feedback.

Thanks for the feedback! It's a good point, I actually started a new PHP+database project two weeks ago for the first time in forever, and found out that my UTF-8 varchar columns can actually only be about 21 thousand bytes. I didn't realize this project would have that bug -- it didn't manifest in my original setup from 2016 since I (apparently) used the latin1 character set back then (I assume that used to be the default).

Do you want to create a pull request so that your contribution ends up in the commit log of this project?