restrict qualifier collision

Question

restrict qualifier collision

revelator opened this issue 8 years ago · 6 comments

Been having trouble for some time with the restrict qualifier, and i suspected a bug with the mingw-w64 abi, but it turns out that mcfgthread redefines the qualifier in its own _crtdef.h which causes this error.
So i changed it to use a guard in case its allready defined which seems to have alleviated the problem.

Answer 1 · 2017-01-13T12:11:24.000Z

restrict itself is a keyword in C today but the C++ people don't seem to like it...
GCC provides __restrict__ as an alternative that is available in both C and C++ and has the same meaning with the restrict keyword in C.

I was concerned that #define'ing restrict and nullptr would break some existent code because they aren't reserved identifiers... It turns out to be a bad choice I must acknowledge.

AFAIC the safest solution to this problem is using __restrict__ only in our code and removing that macro.

Answer 2 · 2017-01-13T16:48:47.000Z

New commits pushed. Please test.

Answer 3 · 2017-01-14T08:07:28.000Z

Will do, im making a build of the gcc-5.4.0 release which im going to stick to untill the problem with the hardcoded paths in gcc 6 are resolved. Den 13-01-2017 kl. 17:48 skrev LH_Mouse:

…

New commits pushed. Please test. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#19 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB1zkJC4G2rIl917w0lePoYTwqZgQEzhks5rR6rvgaJpZM4LisJ3>.

Answer 4 · 2017-01-14T17:39:02.000Z

Seems to work so far :) codelite still bitches about restrict but that one seems to be simply because its using the qualifier incorrectly as an internal enumerator, so cant blame it on the former error. I made a patch to get around that one, but there are other problems with codelite which break it though. Den 13-01-2017 kl. 17:48 skrev LH_Mouse:

…

New commits pushed. Please test. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#19 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB1zkJC4G2rIl917w0lePoYTwqZgQEzhks5rR6rvgaJpZM4LisJ3>.

Answer 5 · 2017-01-15T08:36:40.000Z

OK for closure?

Answer 6 · 2017-01-15T09:12:18.000Z

Yep :) and thanks for fixing. Den 15-01-2017 kl. 09:36 skrev LH_Mouse:

…

OK for closure? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#19 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB1zkAzOtb5O1lIFYxGI8i99dK-rqjrLks5rSdqYgaJpZM4LisJ3>.