liamg/traitor

Build instructions incorrect?

taoeffect opened this issue · 9 comments

taoeffect commented

Hi, I'd like to install following these instructions from the README but am not sure how to get the binary built:

CGO_ENABLED=0 go get -u github.com/liamg/traitor/cmd/traitor

This creates a go/pkg folder with a bunch of subfolders, but I have no idea where the built binary is.

Any help greatly appreciated! Using go 1.16.8.

prologic commented

@taoeffect What version of Go do you have installed?

taoeffect commented

@prologic I mentioned it in the issue, see the very last sentence

prologic commented

@prologic I mentioned it in the issue, see the very last sentence

My apologies I didn't see that due to my vision impairment 😅 Soo according to the Go 1.16 Release Notes you shoudl now use go install <package>@<version> to install packages that contain a package main such as what cmd/traitor provides.

Example:

$ go install github.com/liamg/traitor/cmd/traitor@latest

Tested on my iMac.

taoeffect commented

When I run that I get this:

$ go install github.com/liamg/traitor/cmd/traitor@latest
go/pkg/mod/github.com/liamg/traitor@v0.0.9/pkg/exploits/all.go:5:2: //go:build comment without // +build comment
prologic commented

Sorry I can't explain what's going on there :/

liamg commented

What architecture are you building on? If building is an issue, you can probably take one of the prebuilt binaries from the latest release.

taoeffect commented

@liamg fedora linux.

If building is an issue, you can probably take one of the prebuilt binaries from the latest release.

Thanks, when I checked last they weren't there for 0.0.14, but now they are.

taoeffect commented

*I edited the issue title to "Build instructions incorrect?", can this issue be reopened since they still aren't working?