Upgrade to Android plugin 3.x
keesvandieren opened this issue · 8 comments
The Android Gradle plugin needs to be upgraded to last version.
Currently project doesn't build with latest Gradle plugin (see also: #180 (comment))
Due to lack of time, I cannot do the upgrade currently. If anyone is willing to take up this task, I will be happy to accept PR.
I started the work here: https://github.com/libgdx/gdx-pay/tree/android-build-tools-3-upgrade, but ./gradlew check fails with lint errors. Not yet dived into details.
Maybe @ProZhar or @MrStahlfelge have some time left ;-)?
libGDX is not compatible with Gradle plugin >= 3
libgdx/libgdx#4698
libgdx/libgdx#5177
We have to stay on 2.x.
I have not build problems with gdx-pay and my normal libGDX configuration.
@keesvandieren I would love to help, but I don’t know well gradle and its plugin :(
4.6 is now supported by 1.9.9 and 1.9.8
PR is made, but it has lint problems: #185
I was able to manage the lint problem, it was caused by the gdx-pay-android project not being an actual Android project. Next problem was with the unmock library, changed to the latest version fixed it.
Now the build fails on signing the test project. I tried a lot of different Travis commands but no success. Problem is, I don't get this error locally: it works when I build and test on my machine.
It is building :)
@keesvandieren Because we update the minimum libGDX version from 1.9.6 to 1.9.8, I would suggest to release 0.11.4 before merging this to the master branch. This way, 0.11.4 can still be used with 1.9.6 and 1.9.7 if some users need it.
Release 0.11.4 was made with the old build system.
I have now merged the build tools branch and incremented the gdx-pay version number to 0.12.0-SNAPSHOT to reflect that the underlying libGDX version has also increased to 1.9.8. The new SNAPSHOT version is published. I checked if it is working to pull the new version with both Gradle 4.6 and Gradle 3.3 and it does. So I am closing this issue.