libimobiledevice/libusbmuxd

Commit ca24570 breaks `flutter run` command

christopherfujino opened this issue · 4 comments

christopherfujino commented

There are multiple reports (35102, 34925, 35099) of the latest HEAD (since ca24570) breaking flutter run. Could you please revert?

JonGabilondoAngulo commented

I can confirm that this push is braking our communication to the device too.
Reverting the push solves the problem.

nikias commented

@christopherfujino I don't know how flutter is using the library exactly. It's a very simple fix and instead of demanding a revert of a mandatory change it would only be straight forward to fix the issue on the other side, in this case flutter.
I realized though that iproxy was broken in fact, which I just fixed with commit 6539b02. If flutter is only using iproxy, then this would solve the problem.
@JonGabilondoAngulo you don't even mention how you do your communication.
As a general rule to adapt to the changes:

  • Before commit ca24570, a timeout was basically a usbmuxd_recv or usbmuxd_recv_timeout with a return value of 0 (success) while setting the number of bytes received (via recv_bytes parameter) to 0.
  • Starting with commit ca24570, code expecting a timeout needs to check for an error code of -ETIMEDOUT to know if a timeout occurred or not. But also recv_bytes will be 0 in that case.
  • 👍2
amake commented

I can't speak as to exactly how Flutter uses libusbmuxd, but 6539b02 does indeed appear to fix the issue. Thank you!

christopherfujino commented

Thanks @nikias, closing this issue as it appears resolved!