libp2p/test-plans

js-libp2p webrtc tests flaky

Closed this issue · 7 comments

MarcoPolo commented

Related: libp2p/js-libp2p#1846

There's a lot of stuff in the stack, so this needs investigation as to what is being flaky. Is it:

  • js-libp2p
  • js-libp2p-webrtc
  • js-libp2p circuitV2
  • js-libp2p p2p-circuit transport
  • Browser itself
  • Something else?

My hope is that it's not the browser as everything else is easier to fix. Maybe a very simple non-js-libp2p browser only interop test would be a good way to test if the browser is at fault.

maschad commented

Thanks for writing this up.

My hope is that it's not the browser as everything else is easier to fix. Maybe a very simple non-js-libp2p browser only interop test would be a good way to test if the browser is at fault.

Just to clarify, when you reference browser in this context are you referring to https://github.com/hugomrdias/playwright-test which aegir uses for browser testing right?

MarcoPolo commented

I would use https://playwright.dev directly, avoiding Aegir and playwright-test.

I'll probably do this at some point this week, but if you have bandwidth and it seems interesting, let me know and you can take.

maschad commented

Good point, Thanks for clarifying. I will take a look into it this week.

MarcoPolo commented

Sounds good. Let's sync up when you get a chance.

sukunrt commented

Is there any update here? We are adding support for webrtc in go-libp2p and it'd be nice to test interop with js-libp2p. I have pretty much copied the js-libp2p test implementation: libp2p/go-libp2p#2584

maschad commented

We will revisit once libp2p/js-libp2p#2074 is merged, this issue is causing the current webRTC tests to be flaky in js-libp2p