Add print concatenation
danomatika opened this issue · 7 comments
Looks like libpd in pd-for-android is not being built with the extras externals, judging from this issue: libpd/libpd#112
This means expr, expr~, & fexpr~ aren't available as well as sigmund~, bob~, etc.
Also, I'd suggest adding the print concatenation layer so prints are grouped per line as opposed to the per word default: https://github.com/libpd/libpd/blob/master/libpd_wrapper/util/z_print_util.h
@danomatika I've just tested this and it seems to me that all of these objects that you mentioned are included except for bob~ , so I don't think that this is the issue with libpd/libpd#112
This is what I used to test:
https://github.com/tkirshboim/pd-for-android-test
If you want to test all the EXTRAS, add these to the list: bonk~, loop~, choice, lrshift~, pique, stdout
Following this good idea, I added a test patch with all the extras objects to the c pdtest: libpd/libpd@dca1c41
This way we can double check the fault is not in the libpd c core.
EDIT: With a build of the current master branch, all objects create.
I added all the extra objects from the test patch you created on libpd.
All of those extras could be created apart from bob~ and stdout.
I don't know if this issue was recently introduced and if those objects were included in Android builds in the past. Will have to look into that.
bob~ is new as of at least 6 months ago. Assuming the android build doesn't use the libpd makefile, I bet the build is just missing those c files.
I see. So perhaps simply adding those extras to the https://github.com/libpd/libpd/blob/master/Android.mk will fix it. I'll give it a try.
Yup, looks like those are missing from the .so build targets. Easy enough!