Only 24-hr graphs show
paraviz02 opened this issue · 13 comments
For all periods of time (week, year, 24 hour, etc) the 24 hour graph shows.
This is on the new iOS version with the CORS fix on the server.
Hmm, I'm unable to replicate this. The graphs are loading fine on my dev and prod servers.
I'm pushing the cors update to apple today so once this is through I'll troubleshoot this some more.
Very interesting.
One other thing - we are using iPhone X and noticed that we now have full screen (yay!) but there are some interesting layout/format issues.
This may be related.
Will look forward to the new update. Thanks for your efforts!
Here’s a couple screenshots for you:
Funny layout on iPhone X:
All 24-hr graphs:
Can confirm it's showing the same graphs. From the logs:
1.1.1.1 - - [14/Jan/2018:20:11:52 +0000] "GET /api/v0/devices/398/device_hr_processes?from=end-24h&to=now&width=667&height=200 HTTP/2.0" 200 19967 "http://localhost:8080/var/containers/Bundle/Application/AEEC6533-050E-431C-8FA7-A01DD3509A93/myLibreNMS.app/www/index.html" "Mozilla/5.0 (iPhone; CPU iPhone OS 11_2_2 like Mac OS X) AppleWebKit/604.4.7 (KHTML, like Gecko) Mobile/15C202"
1.1.1.1 - - [14/Jan/2018:20:11:53 +0000] "GET /api/v0/devices/398/device_hr_processes?from=end-1m&to=now&width=667&height=200 HTTP/2.0" 200 14757 "http://localhost:8080/var/containers/Bundle/Application/AEEC6533-050E-431C-8FA7-A01DD3509A93/myLibreNMS.app/www/index.html" "Mozilla/5.0 (iPhone; CPU iPhone OS 11_2_2 like Mac OS X) AppleWebKit/604.4.7 (KHTML, like Gecko) Mobile/15C202"
1.1.1.1 - - [14/Jan/2018:20:11:53 +0000] "GET /api/v0/devices/398/device_hr_processes?from=end-1y&to=now&width=667&height=200 HTTP/2.0" 200 15792 "http://localhost:8080/var/containers/Bundle/Application/AEEC6533-050E-431C-8FA7-A01DD3509A93/myLibreNMS.app/www/index.html" "Mozilla/5.0 (iPhone; CPU iPhone OS 11_2_2 like Mac OS X) AppleWebKit/604.4.7 (KHTML, like Gecko) Mobile/15C202"
1.1.1.1 - - [14/Jan/2018:20:11:53 +0000] "GET /api/v0/devices/398/device_hr_processes?from=end-1w&to=now&width=667&height=200 HTTP/2.0" 200 20520 "http://localhost:8080/var/containers/Bundle/Application/AEEC6533-050E-431C-8FA7-A01DD3509A93/myLibreNMS.app/www/index.html" "Mozilla/5.0 (iPhone; CPU iPhone OS 11_2_2 like Mac OS X) AppleWebKit/604.4.7 (KHTML, like Gecko) Mobile/15C202"
It looks like the from= parts. These should just be -1w, -1y, etc.
I'm trying to get a dev env setup to take a look.
I see what you're saying. I think i found this now. Will fix in same patch. Thanks for the help @laf
Rock on, @pheinrichs ... And thanks @laf for the info!
Y'all are awesome. Thanks again for the beautiful work.
I’ll submit a pr if you like. Got the fix done.
Submitted my fix. Works using ionic serve
1.2.1 push to apple store. Pending approval.
New update is in stores now. Let me know if this resolved your issue @paraviz02 and we can close this.
Thanks so much! Just checked my App Store, still waiting on it to get out my way. Looking forward to it!
I will let you know as soon as I check it out. Thanks again @pheinrichs.
Yep! All fixed for the graphs.
However, the new version reverted to pre-iPhone X view size on iPhone X. :-)
You may close the issue, as reported, all fixed!
Great to hear. I changed the viewport back to the original to avoid the cors issue. I'll look into other possible solutions for iPhone X in future updates.
Thanks for letting me know.