Custom config file not working (-c)

[sooslaca]

Description

Custom config file not being parsed.

Steps to reproduce

Copy settings.toml to a different directory
Change eg listen_port to 8990
start: speedtest-go.exe -c c:\path_to_file\settings.toml
Program still bind to 8989

Expected behaviour

Use given config

Findings

viper: Reading Config Files says:
viper.SetConfigType("yaml") // REQUIRED if the config file does not have the extension in the name

https://github.com/librespeed/speedtest-go/blob/master/config/config.go#L84

There is no ConfigType defined in here

Either should use ReadInConfig or shall set ConfigType before ReadConfig.

Thanks

[maddie]

Thanks for your report.

I've tested locally and I cannot reproduce your issue, though I've only tested on Linux and macOS. And also there have been PRs against the configuration part in the past, and during the testing, no such problem was found.

Check your settings.toml again and make sure the values are right and also the path to it. I'm not really sure what's happening here, but if I had to guess, it could be the way that Go handles the path string under Windows. Maybe you can try adding quotes to the path or escaping the path separator (e.g. C:\\path_to_file\\settings.toml).

For the viper documentation part you've referenced to, it says it's required only if the config file given does not have an extension name. The fact that you gave ....\settings.toml to the -c option, it already tells Viper to parse it as a toml file. It's not necessary to set it explicitly to toml, and I didn't do so because there might be some user that is used to another format (i.e. JSON) for their configuration and they can still use it.

[sooslaca]

Thanks for checking, I’m away now cannot check until Tuesday.
Maybe your go cache using older viper?

In the config.go code I remember you gave io.Reader as a parameter to viper. ReadConfig
Hence it would not matter what the file suffix is as that routine will never see that information, given that the file is opened files before for reading, right?

What did you try with? Toml format from a different directory? I did try that, maybe yaml is the default for viper that’s why it worked.

Thank you

[maddie]

Hmm, I don't think I've used an io.Reader, I just used viper.ReadInConfig:

speedtest-go/config/config.go

Lines 54 to 71 in c815103

	func Load() Config {
	var conf Config
	if err := viper.ReadInConfig(); err != nil {
	if _, ok := err.(viper.ConfigFileNotFoundError); ok {
	log.Warnf("No config file found in search paths, using default values")
	} else {
	log.Fatalf("Error reading config: %s", err)
	}
	}
	if err := viper.Unmarshal(&conf); err != nil {
	log.Fatalf("Error parsing config: %s", err)
	}
	loadedConfig = &conf
	return conf
	}

I don't even have an io.Reader in the whole config.go file.

And I think it rules out using the older version of viper since we're using Go modules here unless the viper authors published a bug fixed release under the same version, which I doubt that they would do.

[sooslaca]

I might be wrong, but Load only kicks in if you don't give config file:

speedtest-go/main.go

Line 25 in c815103

conf = config.Load()

you need to look in LoadFile:

speedtest-go/config/config.go

Line 84 in c815103

if err := viper.ReadConfig(f); err != nil {

[maddie]

Hmm, I see, I was looking at the wrong place.

I've pushed a commit to let Viper read the file instead of me opening it manually, and I've tested it to be working for both toml and json.

Could you try compiling the master branch and see if it works correctly for you now?

Thanks.

[sooslaca]

awesome, thank you ! It works like a charm now.

[maddie]

Thanks, I'll make a new release now :)