uninstall target should maybe only be generated if installed?

Question

uninstall target should maybe only be generated if installed?

Closed this issue 6 months ago · 4 comments

https://github.com/libressl/portable/blob/master/CMakeLists.txt#L530-L543

I would think that if(NOT TARGET uninstall) section should be included in the block above it if(ENABLE_LIBRESSL_INSTALL) such that if there is no install, then no uninstall should be generated?

d3x0r commented 6 months ago

yes

Answer 1 · 2024-03-19T02:26:13.000Z

Here's a visual of generated projects - at the end is 'uninstall' which comes from libressl.

The option to skip install is on, because I'm just linking against the static libraries that are built, so there's no install to do, therefore there should also be nothing to uninstall...

Answer 2 · 2024-03-19T02:34:25.000Z

I see. As I mentioned, I'm happy to merge a PR that does this.

Answer 3 · 2024-04-08T08:29:38.000Z

This is solved by the merge of #1043, right?