`compat/stdint.h` missing from source tarball

Question

`compat/stdint.h` missing from source tarball

Closed this issue a month ago · 7 comments

While skimming commits I noticed that the codebase does actually
tackle the case where OpenBSD-specific __bound__ attribute is
not supported by the compiler. The logic was moved to compat/stdint.h
in 3a75727 (2023-07-05),
but this header is missing from the tarball as of v3.9.2.

Would the presence of this header fix the GCC compiler warnings in
chacha-merged.c mentioned here?:
#910 (comment)

If so, I wonder if it'd be a good idea to add it to the tarball, but could not
figure out the script responsible for this.

Answer 1 · 2024-06-05T18:47:21.000Z

I've neutered that with a bigger hammer: openbsd/src@65010fa

Answer 2 · 2024-06-05T18:47:49.000Z

Perhaps this?:

diff --git a/include/Makefile.am b/include/Makefile.am
index 22819c8..feaaa60 100644
--- a/include/Makefile.am
+++ b/include/Makefile.am
@@ -17,6 +17,7 @@ noinst_HEADERS += compat/poll.h
 noinst_HEADERS += compat/pthread.h
 noinst_HEADERS += compat/readpassphrase.h
 noinst_HEADERS += compat/resolv.h
+noinst_HEADERS += compat/stdint.h
 noinst_HEADERS += compat/stdio.h
 noinst_HEADERS += compat/stdlib.h
 noinst_HEADERS += compat/string.h

Answer 3 · 2024-06-05T18:51:29.000Z

I've neutered that with a bigger hammer: openbsd/src@65010fa

Ah, nice, thanks!

That said compat/stdint.h has some other things in it as well. If there,
it might make sense distributing?

Answer 4 · 2024-06-05T19:01:19.000Z

On Wed, Jun 05, 2024 at 11:48:11AM -0700, Viktor Szakats wrote: Perhaps this?:

Yes, that's it. Care to make this a PR?

Answer 5 · 2024-06-05T19:06:53.000Z

There it is: #1065

Answer 6 · 2024-06-05T19:28:30.000Z

Thanks. And this should indeed fix this warning. I'll double check and revert the hack in chacha-merged.c

Answer 7 · 2024-06-06T00:11:11.000Z

Hmm, this file has been here for 6 years and never made an appearance in the distributed tarballs. Darn, sorry about that.