libressl/portable

LibreSSL 3.7.x doesn't have RAND_OpenSSL()

orbea opened this issue · 2 comments

orbea commented

When building tpm2-tss it fails since OpenSSL_rand() is not implemented.

https://github.com/tpm2-software/tpm2-tss/blob/3d3c9a81db1354fe75dd27f5a87551c101034b0d/src/tss2-esys/esys_crypto_ossl.c#L561

This can be easily worked around.

#ifdef LIBRESSL_VERSION_NUMBER
    RAND_set_rand_method(RAND_SSLeay());
#else
    RAND_set_rand_method(RAND_OpenSSL());
#endif

But reading LibreSSL's documentation it shows that RAND_set_rand_method() and RAND_SSLeay() doesn't really do anything. Perhaps the same should be for RAND_OpenSSL()?

I made WIP upstream PR here. tpm2-software/tpm2-tss#2380

4a6f656c commented

RAND_set_rand_method() and RAND_OpenSSL() are deprecated in OpenSSL 3.0 onwards:

https://www.openssl.org/docs/man3.0/man3/RAND_set_rand_method.html

For upstream patches, I would recommend using:

#ifndef LIBRESSL_VERSION_NUMBER
RAND_set_rand_method(RAND_OpenSSL());
#endif

Or potentially removing/replacing the code in question.

orbea commented

RAND_set_rand_method() and RAND_OpenSSL() are deprecated in OpenSSL 3.0 onwards:

Thanks for pointing that out, I missed that detail. It doesn't seem to make sense to start adding deprecated functions so I will close this.