libressl/portable

3.8.0: CMake with MinGW fails to enable ASM support + ASM builds crashing

vszakats opened this issue · 2 comments

vszakats commented

  • Patch fixing the two build issues:

    1. MinGW detection to use MINGW variable instead of expecting specific CMAKE_SYSTEM_NAME values (this may be "Windows" even for MinGW builds.)
    2. Do not disable ASM support for MinGW.

    PR: #894

  • The next issue is that ASM-enabled LibreSSL creates bad executables. They seems to crash before even starting.
    It's a regression in 3.8.0. ASM-enabled 3.7.3 builds run fine.

vszakats commented

The only difference between 3.7.3 and 3.8.0 ASM sources is the addition of endbr64 instructions in 3.8.0. [ "Added endbr64 instructions to amd64 assembly." in ChangeLog. ]

OpenSSL added support for this in 2020, but it's not actually present in the x86_64 ASM sources generated for the MinGW target (haven't tested others), as seen in a recent 3.0.8 build.

vszakats commented

The part involving this repo is fixed now, so closing.