libressl/portable

(CID 471970) crypto/ec/ec_ameth.c: checked return is suspected by coverity

chipitsine opened this issue · 2 comments

chipitsine commented

looks like we can mark this as "intended" in coverity (since we return 1) ?

*** CID 471970:  Error handling issues  (CHECKED_RETURN)
/home/runner/work/portable/portable/crypto/ec/ec_ameth.c: 599 in old_ec_priv_decode()
593     {
594             EC_KEY *ec;
595             if (!(ec = d2i_ECPrivateKey(NULL, pder, derlen))) {
596                     ECerror(EC_R_DECODE_ERROR);
597                     return 0;
598             }
>>>     CID 471970:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "EVP_PKEY_assign" without checking return value (as is done elsewhere 33 out of 38 times).
599             EVP_PKEY_assign_EC_KEY(pkey, ec);
600             return 1;
601     }
602     
603     static int
604     old_ec_priv_encode(const EVP_PKEY *pkey, unsigned char **pder)
botovq commented
botovq commented