Not recognizing compressed German versions of Day of the Tentacle and Simon the Sorcerer
Schroedingers-Cat opened this issue · 2 comments
The scanner fails to recognize the German versions of Day of the Tentacle (CD) and Simon the Sorcerer (DOS/CD) if the audio files have been compressed with the ScummVM tools. This is happening because the database only looks for the original audio file:
rom ( name "MONSTER.SOU" size 238267139 crc ba6467a2 md5 8ea07a3e13af00f0a6e594820df1a9af sha1 8ea8934f1ef9e212e26fbd72463c9d0c42af8ee7 )
For other languages, the TENTACLE.000 is being checked, which should make the scanner work for non-German versions with compressed audio files.
Maybe the TENTACLE.000 file could be used to identify the German CD version of DotT? I still have the original disc so I could create a PR for that.
The situation is similar with Simon the Sorcerer which uses the file SIMON.WAV for identifying the German CD version while SIMON.GME is used to identify the English CD version. With this one, I also wonder if the German version could be identified by the SIMON.GME file, which has a different hash than the English version. I could also share this via a merge request.
Let me know what you think.
Let's manually add the entry over at https://github.com/RobLoach/libretro-database-scummvm/blob/master/manual-games.json
That script will construct the scummvm database. The trick is that there can't be duplicate CRC entries across different languages/versions.
Thanks for pointing me to that. MR is up here: RobLoach/libretro-database-scummvm#21