libretro/virtualjaguar-libretro

Windows port build fails

Closed this issue · 4 comments

lordashram commented

I get the following when compiling with MinGW-w64:

In file included from libretro.cpp:13:0:
src/settings.h:11:19: error: '_POSIX_PATH_MAX' was not declared in this scope
 #define MAX_PATH  _POSIX_PATH_MAX
                   ^
src/settings.h:46:15: note: in expansion of macro 'MAX_PATH'
  char ROMPath[MAX_PATH];
               ^
src/settings.h:11:19: error: '_POSIX_PATH_MAX' was not declared in this scope
 #define MAX_PATH  _POSIX_PATH_MAX
                   ^
src/settings.h:47:19: note: in expansion of macro 'MAX_PATH'
  char jagBootPath[MAX_PATH];
                   ^
src/settings.h:11:19: error: '_POSIX_PATH_MAX' was not declared in this scope
 #define MAX_PATH  _POSIX_PATH_MAX
                   ^
src/settings.h:48:18: note: in expansion of macro 'MAX_PATH'
  char CDBootPath[MAX_PATH];
                  ^
src/settings.h:11:19: error: '_POSIX_PATH_MAX' was not declared in this scope
 #define MAX_PATH  _POSIX_PATH_MAX
                   ^
src/settings.h:49:18: note: in expansion of macro 'MAX_PATH'
  char EEPROMPath[MAX_PATH];
                  ^
src/settings.h:11:19: error: '_POSIX_PATH_MAX' was not declared in this scope
 #define MAX_PATH  _POSIX_PATH_MAX
                   ^
src/settings.h:50:21: note: in expansion of macro 'MAX_PATH'
  char alpineROMPath[MAX_PATH];
                     ^
src/settings.h:11:19: error: '_POSIX_PATH_MAX' was not declared in this scope
 #define MAX_PATH  _POSIX_PATH_MAX
                   ^
src/settings.h:51:18: note: in expansion of macro 'MAX_PATH'
  char absROMPath[MAX_PATH];
                  ^
Makefile:190: recipe for target 'libretro.o' failed
make: *** [libretro.o] Error 1
Failed to build VirtualJaguar
clobber commented

hrm yeah, it's failing here: https://github.com/libretro/virtualjaguar-libretro/blob/master/src/settings.h#L9-L14

Can you remove -D__GCCUNIX__ from the makefile and try again?

Oggom commented

Not him, but after removing -D__GCCUNIX__ I'm getting this:

src/blitter.cpp: In function 'void BlitterMidsummer2()':
src/blitter.cpp:3975:96: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
inc |= (phrase_mode && (((pixsize == 3 || pixsize == 4) && (inct & 0x02)) || pixsize == 5 && !(inct & 0x01)) ? 0x02 : 0x00);
^
Makefile:190: recipe for target 'src/blitter.o' failed
make: *** [src/blitter.o] Error 1

r-type commented

With MinGW-w64 ,
after remove -D__GCCUNIX__ and add -DMAX_PATH=4096
everything compile fine on win for me .

I change CXXFLAGS += $(FLAGS) -D__GCCUNIX__
to CXXFLAGS += $(FLAGS) -DMAX_PATH=4096

i thinks we add this flags if mingw detected.

Oggom , you point only a warning not an error. the error you have should be elsewhere.

lordashram commented

Compiles and works now, thank you very much.